Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: CVE in codebase #1845

Open
1 task done
shivamsouravjha opened this issue Apr 22, 2024 · 6 comments · May be fixed by #2137
Open
1 task done

[bug]: CVE in codebase #1845

shivamsouravjha opened this issue Apr 22, 2024 · 6 comments · May be fixed by #2137
Assignees
Labels
bug Something isn't working keploy kROC Valid Issues that will be considered for kROC Performance evaluation level-3 Major issue or Feature implementation (8 points)

Comments

@shivamsouravjha
Copy link
Contributor

shivamsouravjha commented Apr 22, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

  • There are some vulnerabilities because of dependencies which can be viewed through Red Hat Dependency Analytics

Steps to reproduce

  • Install Red Hat extension on VSCode.
  • Open go.mod file, the RHDA(Red Hat Dependency Analytics) would analyse and then show the report.
  • Click on the pop-up to view the analytics
image

Environment

None

Version

Cloud

Repository

keploy

@shivamsouravjha shivamsouravjha added the bug Something isn't working label Apr 22, 2024
@aerowisca
Copy link
Contributor

seems the CVE was due to an older dependency of docker .
go: upgraded github.com/docker/docker v24.0.4+incompatible => v26.1.1+incompatible
This solves the issue but i hope we are not dependent on particular version for any specific task ? @shivamsouravjha

@shivamsouravjha
Copy link
Contributor Author

nope we're not dependent on any particular docker version, but if we were to upgrade the docker version me must insure that any feature we use isn't downgraded.

@Swpn0neel Swpn0neel added kROC Valid Issues that will be considered for kROC Performance evaluation level-2 Minor bugs or issues (4 points) labels Jun 20, 2024
@shivamsouravjha shivamsouravjha added level-3 Major issue or Feature implementation (8 points) and removed level-2 Minor bugs or issues (4 points) labels Jul 16, 2024
@jaiakash
Copy link

Hi @shivamsouravjha @Swpn0neel, running the RHDA extension in the latest version of Kelpoy gives two errors.

Screenshot 2024-07-21 at 12 41 02 AM Screenshot 2024-07-21 at 12 41 08 AM

The CVSS score is around 5.3 and 6.9. For the fix, I tried upgrading the libraries manually, which solved the issue (it also updated some other dependencies).

I don't know if that's the correct way to solve the issue, as it will require testing deployment with new dependencies.

Could you guide me for this issue? Thanks

@shivamsouravjha
Copy link
Contributor Author

@jaiakash that's the only way out of this issue. Feel free to raise a PR for this and also add a security check in pipeline as to avoid any future issues.

@jaiakash
Copy link

jaiakash commented Jul 22, 2024

@shivamsouravjha Thanks for clarification. You can assign this issue to me.
After upgrading the dependencies, i will add test for it in pipeline. I will raise PR for same.

@jaiakash
Copy link

Hi @shivamsouravjha @Swpn0neel i have added draft PR and need some guidance on that. Please checkout #2137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keploy kROC Valid Issues that will be considered for kROC Performance evaluation level-3 Major issue or Feature implementation (8 points)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants