Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Installation guide link in the readme #1014

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

Adi9235
Copy link
Contributor

@Adi9235 Adi9235 commented Oct 14, 2023

Broken Link in Readme

  • Fixed installation guide broken link in the readme file

Describe the changes you've made

I have changed the link to https://keploy.io/docs/application-development/ in the place of broken link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@github-actions
Copy link

github-actions bot commented Oct 14, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@sweep-ai
Copy link

sweep-ai bot commented Oct 14, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@Adi9235
Copy link
Contributor Author

Adi9235 commented Oct 14, 2023

I have read the CLA Document and I hereby sign the CLA

@Adi9235
Copy link
Contributor Author

Adi9235 commented Oct 14, 2023

retrigger

recheck

Signed-off-by: Aditya Tomar <adi02032002@gmail.com>
Copy link
Member

@Sonichigo Sonichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Sarthak160 Sarthak160 merged commit 501c1c9 into keploy:main Nov 2, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants