Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added timestamp support for test mode #1023

Merged
merged 8 commits into from
Oct 23, 2023
Merged

added timestamp support for test mode #1023

merged 8 commits into from
Oct 23, 2023

Conversation

tomargovind
Copy link
Contributor

Related Issue

  • On deletion of test cases, test cases mismatch with their respective mocks which caused inconsistency in the test mode

Closes: #916

Describe the changes you've made

Added the support for timestamp. Now, mocks will be filtered if it lies inside the test case's request and response timestamp

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

@sweep-ai
Copy link

sweep-ai bot commented Oct 17, 2023 •
edited
Loading

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.

@tomargovind
added timestamp support for mongo
0f59db0 
Signed-off-by: 404fixer <govindtomar94@gmail.com>
@tomargovind
added support for generic parser
02ed1d3 
Signed-off-by: 404fixer <govindtomar94@gmail.com>
@tomargovind
added support for http parser
e8e65dc 
Signed-off-by: 404fixer <govindtomar94@gmail.com>
@tomargovind
added support for postgres parser
79ebc1f 
Signed-off-by: 404fixer <govindtomar94@gmail.com>
@tomargovind
added support for grpc parser
de5a614 
Signed-off-by: 404fixer <govindtomar94@gmail.com>
charankamarapu
charankamarapu reviewed Oct 22, 2023
View reviewed changes
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments

pkg/service/test/util.go Show resolved Hide resolved
pkg/models/http.go Show resolved Hide resolved
pkg/hooks/connection/tracker.go Show resolved Hide resolved
pkg/hooks/connection/factory.go Outdated Show resolved Hide resolved
pkg/proxy/integrations/postgresParser/postgres_parser.go Show resolved Hide resolved
@tomargovind
better error handling
1f67469 
Signed-off-by: 404fixer <govindtomar94@gmail.com>
charankamarapu
charankamarapu reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the comments

pkg/service/test/util.go Outdated Show resolved Hide resolved
@tomargovind
improved error handling
e8e3715 
Signed-off-by: 404fixer <govindtomar94@gmail.com>
charankamarapu
charankamarapu reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the typo

pkg/service/test/util.go Outdated
}

if tc.HttpResp.Timestamp == (time.Time{}) {
logger.Warn("response timestamp is misssing of " + tc.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo error "missing" and instead of "of" use "for"

@tomargovind
fixed typo
860448c 
Signed-off-by: 404fixer <govindtomar94@gmail.com>
charankamarapu
charankamarapu approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

re-Tick
re-Tick approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@re-Tick re-Tick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@re-Tick re-Tick merged commit 483b778 into keploy:main Oct 23, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sarthak160 Sarthak160 Sarthak160 left review comments

@re-Tick re-Tick re-Tick approved these changes

@charankamarapu charankamarapu charankamarapu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: TestCase deletion from test-set causing test run failure
4 participants
@tomargovind @Sarthak160 @re-Tick @charankamarapu