-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed repititve function definitions #1035
Conversation
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Apply Sweep Rules to your PR?
|
@Sarthak160 please review this PR |
And also Remove |
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -10,6 +10,7 @@ import ( | |||
"go.keploy.io/server/pkg/hooks" | |||
"go.keploy.io/server/pkg/models" | |||
"go.uber.org/zap" | |||
"go.keploy.io/server/pkg/proxy/util" | |||
) | |||
|
|||
func PostgresDecoder(encoded string) ([]byte, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EraKin575 func PostgresDecoder and func PostgresEncoder are also used for generic payload , you can rename them to func GenericDecoder
and move them to util/utils.go as well .
Related Issue
Closes: #1033
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Type of change
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)A clear and concise description of it.
Checklist:
Screenshots (if any)