Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed repititve function definitions #1035

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

EraKin575
Copy link
Contributor

@EraKin575 EraKin575 commented Oct 20, 2023

Related Issue

  • Info about Issue or bug

Closes: #1033

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
@sweep-ai
Copy link

sweep-ai bot commented Oct 20, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@EraKin575 EraKin575 changed the title removed repitive function definitions removed repititve function definitions Oct 20, 2023
@EraKin575
Copy link
Contributor Author

@Sarthak160 please review this PR

@Sarthak160
Copy link
Member

And also Remove func CreateShingles(data []byte, k int) from postgres utils as it's used nowhere .

Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Copy link
Member

@Sarthak160 Sarthak160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -10,6 +10,7 @@ import (
"go.keploy.io/server/pkg/hooks"
"go.keploy.io/server/pkg/models"
"go.uber.org/zap"
"go.keploy.io/server/pkg/proxy/util"
)

func PostgresDecoder(encoded string) ([]byte, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EraKin575 func PostgresDecoder and func PostgresEncoder are also used for generic payload , you can rename them to func GenericDecoder and move them to util/utils.go as well .

@Sarthak160 Sarthak160 merged commit 0e1a326 into keploy:main Oct 24, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
@EraKin575 EraKin575 deleted the dev/util branch October 24, 2023 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: move duplicate functions from different parser into single utility file
2 participants