fix: Removed unneccessary logs and updated the version for sentry #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Apply Sweep Rules to your PR?
|
main.go
Outdated
| @@ -15,7 +15,7 @@ import ( | |||
| // see https://goreleaser.com/customization/build/ | |||
|
|
|||
| var version string | |||
| var dsn string | |||
| var Dsn string | |||
There was a problem hiding this comment.
why did you change this ..?
main.go
Outdated
| @@ -34,12 +34,14 @@ func main() { | |||
| version = "2-dev" | |||
| } | |||
| fmt.Println(logo, " ") | |||
| fmt.Printf("version: %v\n\n", version) | |||
| fmt.Printf("%v\n\n", version) | |||
There was a problem hiding this comment.
why did you change this..?
utils/utils.go
Outdated
| @@ -10,6 +10,8 @@ import ( | |||
| sentry "github.com/getsentry/sentry-go" | |||
| ) | |||
|
|
|||
| var VersionForSentry string | |||
There was a problem hiding this comment.
The naming itself is wrong, are we using this version sentry..? just keep it keployVersion.
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Currently a hardcoded version is injected into sentry . Need to inject correct keploy version.
Closes: #1095 #1032
Describe the changes you've made
Updated the location of keploy logs and deleting the logs as soon as keploy stops. Also removed unncessary logs from the utils package, also updated the version updating mechanism
Type of change
Checklist: