fix: the logic to compare two slices should be changed

[AkashKumar7902]

Related Issue

• Info about Issue or bug

Closes: #1099

Describe the changes you've made

changed the comparison logic to compare two slices in jsonMatch() function.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, local variables)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

• My code follows the style guidelines of this project.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original	Updated
original screenshot	updated screenshot

[AkashKumar7902]

@charankamarapu I Have made the changes

[AkashKumar7902]

@charankamarapu I believe code snippets in https://keploy.io/docs/running-keploy/configuration-file/ need an update. Should I create an issue ?

[charankamarapu]

what change is needed there?

[AkashKumar7902]

global noise field in yaml is now changed from string. So the value of the globalnoise field needs an update

[charankamarapu]

Currenly this is present in the docs, what will it be changed to ..?

globalNoise: |-
       {
         "global": {
           "body": {},
           "header": {}
         },
         "test-sets": {
           "test-set-name": {
             "body": {},
             "header": {}
           }
         }
       }

[AkashKumar7902]

Also some new fields are/will be added in keploy-config.

[charankamarapu]

Who ever adds the new fields will change the doc too. Have you added any new field..?

[charankamarapu]

Currenly this is present in the docs, what will it be changed to ..?

globalNoise: |-
       {
         "global": {
           "body": {},
           "header": {}
         },
         "test-sets": {
           "test-set-name": {
             "body": {},
             "header": {}
           }
         }
       }

Got it. The key strings will not be there. Please go head and create the issue but create the PR only after this PR is merged.

[charankamarapu]

Please address the comments

[charankamarapu]

I think we shouldn't give this test-set-name in the default config because people will just run it and keploy thinks test-set-name is name of the test set and it will search for test-set-name. Just write test-sets: and leave it . Above the globalNoise: write a comment that to use global noise please follow the guide at the end of the yaml.

[charankamarapu]

Have you checked the case where I dont give Testsets noise at all..? like this :

globalNoise:
    global:
      body: {}
      header: {}

If I don't give test-sets noise at all will it throw an error while converting from yaml to go struct.

In the same way if I just include this without header json will it throw an error or ignore it.

globalNoise:
    global:
      body: {}

[charankamarapu]

I have tested this from my end it is working fine. Please resolve the other comment.

[AkashKumar7902]

@charankamarapu I have made the changes

[charankamarapu]

hey @AkashKumar7902 , can you check why the github action is failing mostly because of changes in config file. Mostly due to backward compatability it was unable to detect noise I guess, can you check once.?

[charankamarapu]

@AkashKumar7902 Is the PR ready for review or are there any changes..?

[charankamarapu]

Please address the comments

[charankamarapu]

may be just remove this test-sets param from here, people can understand how to use it from comments below.

[AkashKumar7902]

done !

[charankamarapu]

Ship it!