Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test cases not running #1110

Conversation

AkashKumar7902
Copy link
Member

Related Issue

  • Info about Issue or bug

Closes: #1108

Describe the changes you've made

changed the structure of assertion from map[string]map[string][]string to map[string]interface to support backward compatibility

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Copy link

sweep-ai bot commented Nov 14, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
@charankamarapu
Copy link
Member

@AkashKumar7902 I have mentioned some other bug also in the issue . Please have a look at that.

@AkashKumar7902
Copy link
Member Author

Yeah on it

@charankamarapu
Copy link
Member

To replicate it delete the keploy-config file and run keploy in test mode.

AkashKumar7902 and others added 3 commits November 14, 2023 15:33
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
…es-not-running-because-of-recent-changes-to-the-model'

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

Conflicts:
	pkg/service/test/test.go
@AkashKumar7902
Copy link
Member Author

Hey @charankamarapu,
I have made the changes.
B/w do we want the message "continuing keploy without config file" to be highlighted ?

@charankamarapu
Copy link
Member

It is a logger statement right? Don't highlight it , just let it be as a logger statement.

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@charankamarapu charankamarapu merged commit 2ca3dc0 into keploy:main Nov 14, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: keploy testcases not running because of recent changes to the model
2 participants