Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tls connection in python #1111

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: tls connection in python #1111

merged 1 commit into from
Nov 14, 2023

Conversation

gouravkrosx
Copy link
Member

@gouravkrosx gouravkrosx commented Nov 14, 2023

Related Issue

  • Unable to handle TLS connection in case of Python virtual env, in the regular environment it's working.

Closes: #1107

Describe the changes you've made

  • Set an environment variable REQUESTS_CA_BUNDLE in the case of Python to use our custom CA for TLS connections.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Copy link

sweep-ai bot commented Nov 14, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@gouravkrosx gouravkrosx merged commit b8174e0 into main Nov 14, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: failure in handling TLS connection in python
2 participants