fix(cmd): disable cobra default completion cmd #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Apply Sweep Rules to your PR?
|
|
I have read the CLA Document and I hereby sign the CLA |
slayerjain
added a commit
that referenced
this pull request
Nov 20, 2023
|
Hey @dreamjz the PR is correct and fixes the issue. Could you just complete the DCO check before I merge it? You can see how to pass it by clicking on the Details button. |
* added automatic portChange feature if current port is busy Signed-off-by: EraKin575 <tejaskumar574@gmail.com> * added for for continuous port change if consecutive ports are busy Signed-off-by: EraKin575 <tejaskumar574@gmail.com> * defined a upper and lower bound and maxatempts Signed-off-by: EraKin575 <tejaskumar574@gmail.com> * added a case where the system can't find a available port Signed-off-by: EraKin575 <tejaskumar574@gmail.com> * improved code indentation Signed-off-by: EraKin575 <tejaskumar574@gmail.com> * fixed emoji Signed-off-by: EraKin575 <tejaskumar574@gmail.com> * fixed logger Signed-off-by: EraKin575 <tejaskumar574@gmail.com> * removed useless imports Signed-off-by: EraKin575 <tejaskumar574@gmail.com> * removed unnecessary logs Signed-off-by: EraKin575 <tejaskumar574@gmail.com> --------- Signed-off-by: EraKin575 <tejaskumar574@gmail.com> Signed-off-by: dreamjz <25699818+dreamjz@users.noreply.github.com>
Signed-off-by: dreamjz <25699818+dreamjz@users.noreply.github.com>
dreamjz
force-pushed
the
fix-disable-defualt-completion-cmd
branch
from
47be373
to
2127c13
Compare
|
OK |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes: #1116
Describe the changes you've made
Disable cobra default completion command
Type of change
Please let us know if any test cases are added
NA
Describe if there is any unusual behaviour of your code(Write
NAif there isn't)NA
Checklist:
Screenshots (if any)