Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved halting execution due to keploy config error #1122

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

EraKin575
Copy link
Contributor

@EraKin575 EraKin575 commented Nov 23, 2023

Related Issue

  • Info about Issue or bug

Closes: #1118

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Copy link

sweep-ai bot commented Nov 23, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
@Sarthak160
Copy link
Member

@EraKin575 Please remove the keploy-config.yaml and make changes, As we don't need to put keploy-config.yaml in the main repo . If user wants to use he can create for himself by it's own .

Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Copy link
Member

@Sarthak160 Sarthak160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sarthak160 Sarthak160 merged commit efc9ccf into keploy:main Nov 23, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
@EraKin575 EraKin575 deleted the dev/keploy-config branch November 24, 2023 07:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: errors in keploy-config file should not stop keploy if cli flags are enabled
2 participants