Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:updating return type of report #1124

Merged
merged 12 commits into from
Dec 14, 2023

Conversation

shivamsouravjha
Copy link
Contributor

@shivamsouravjha shivamsouravjha commented Nov 23, 2023

Related Issue

  • Updating the report type

Closes: #1123

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Copy link

sweep-ai bot commented Nov 23, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.

pkg/platform/yaml/yaml.go Outdated Show resolved Hide resolved
@shivamsouravjha shivamsouravjha force-pushed the shivam/mockInterface branch 2 times, most recently from 4e0cfd5 to 95d04cc Compare November 24, 2023 09:05
pkg/platform/interface.go Outdated Show resolved Hide resolved
@re-Tick re-Tick merged commit ead5db3 into keploy:main Dec 14, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: TestCaseDB interface functions can be modified to support interface mock structure.
2 participants