Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sets the auth password for mongo to handle scram authentication #1130

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

re-Tick
Copy link
Contributor

@re-Tick re-Tick commented Nov 24, 2023

Related Issue

  • Fails in test mode for a documentDB application.

Closes: #1129

Describe the changes you've made

Assigns the value of the mongoPassword configured via the test cmd flags to the mongoParser in order to handle the scram authentication.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

I have recorded and tested some APIs of a go and java application which make external calls to DocumentDB.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
Copy link

sweep-ai bot commented Nov 24, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link
Member

@gouravkrosx gouravkrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@re-Tick re-Tick merged commit 0be130f into main Nov 28, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: fails for documentDB auth calls
2 participants