Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove timeout from chunking #1131

Merged
merged 2 commits into from
Nov 25, 2023
Merged

fix: remove timeout from chunking #1131

merged 2 commits into from
Nov 25, 2023

Conversation

charankamarapu
Copy link
Member

Related Issue

Chunked http integration is failed because of the timeout implemented at the httpparser .

Closes: #1127

Describe the changes you've made

The server can take its own time to send the chuck response . There is no time limit in it. But we have introduced a time limit of 5 seconds in our proxy which cause the issue mentioned above. Removed the time out implementation to resolve this issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

I have tested the sample apps provided in the issue and everything worked out fine after implementing changes.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Copy link

sweep-ai bot commented Nov 25, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Copy link
Member

@gouravkrosx gouravkrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@charankamarapu charankamarapu merged commit e11e437 into keploy:main Nov 25, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: chunked http response fails when latency > 5s
2 participants