-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implemented pass through feature for postgres parser #1149
Conversation
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Apply Sweep Rules to your PR?
|
@EraKin575 Please follow the proper commit semantics. You can refer this - https://www.npmjs.com/package/commitizen |
@EraKin575, In the if condition , ideally we should also handle the case if mocks are not loaded till then, so we should call the continue statement after the error handling of the passtrough. Please add that as well ! |
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
@EraKin575 Since passthrough returns nil buffer we dont need to store it in a variable it's not good practice. And also please always do go mod tidy and proper linting practices before pushing any code. See the build logs it's failing because of the error package import but not used anywhere.
|
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
9ea01ad
to
03c4074
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
Closes: #1148
Describe the changes you've made
Added a passthrough feature in postgres parser in case there is failure for matching mocks
Type of change
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)A clear and concise description of it.
Checklist:
Screenshots (if any)