fix: generate config returns after logging error

[officialasishkumar]

Related Issue

The implementation of keploy/pkg/service/generateConfig/generateConfig.go doesn't return in case of error and is subject to nil memory exception.

Closes: #1152

Describe the changes you've made

Added return

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, local variables)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

A clear and concise description of it.

Checklist:

• My code follows the style guidelines of this project.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original	Updated
original screenshot	updated screenshot

[sweep-ai]

Apply Sweep Rules to your PR?

• Apply: All new business logic should have corresponding unit tests.
• Apply: Refactor large functions to be more modular.
• Apply: Add docstrings to all functions and file headers.

[officialasishkumar]

Hey @shivamsouravjha, Can you please review this PR?

[shivamsouravjha]

Try installing go extension and fix the code style. The return terminology isn't right(set code style update)

[officialasishkumar]

Hey @shivamsouravjha, can you please review this?

[shivamsouravjha]

• Quick note on the logging strategy in the code: When we use a logger at the 'fatal' level, the code execution halts automatically at that point. Hence, adding return statements after each 'fatal' logger isn't necessary.

• Also, on choosing between 'Error' and 'Fatal' for logging: 'Fatal' should be used in situations where the application must stop immediately due to a critical issue. This ensures immediate attention to severe problems and prevents the continuation of processes that could be harmful

[shivamsouravjha]

cc @charankamarapu

[shivamsouravjha]

@officialasishkumar are you working on this issue

[officialasishkumar]

I've made the necessary changes. Please take a look @shivamsouravjha

[shivamsouravjha]

@officialasishkumar reformat the code as with a reformat only change is the return statement. Are you using vscode or goland for this?

[shivamsouravjha]

reformat the code as formatting isssue

[officialasishkumar]

@shivamsouravjha PTAL

[shivamsouravjha]

@officialasishkumar congratulations on the PR merge!