Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter when generating keploy-config #1159

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

Hermione2408
Copy link
Member

Related Issue

  • Add filter when generating keploy-config.yaml

Closes: N/A

Describe the changes you've made

Added filters object when generating keploy-config.yaml

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

NA

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Copy link

sweep-ai bot commented Nov 30, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@AkashKumar7902
Copy link
Member

Hey @Hermione2408
I ran generate-config from your branch, looks like the filter field is not properly indented
image

@AkashKumar7902
Copy link
Member

AkashKumar7902 commented Dec 1, 2023

@Hermione2408 I am getting the below error when I try to run record command with the generated config file

🐰 Keploy: 2023-12-01T21:11:21+05:30    ERROR   cmd/record.go:144               {"error": "failed to get the record config from config file due to error: yaml: unmarshal errors:\n  line 10: cannot unmarshal !!str `{\n  \"Re...` into models.Filters"}

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
@Hermione2408
Copy link
Member Author

Can you check now once @AkashKumar7902

@AkashKumar7902
Copy link
Member

@Hermione2408 working good now

Copy link
Member

@Sarthak160 Sarthak160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sarthak160 Sarthak160 merged commit 2ac3047 into keploy:main Dec 5, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants