fix: modified return of nil response for HTTP Connection Error #1174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
When port is changed in the test case after
keploy record
is run, thekeploy test
produces a report which shows that the status isRunning
instead ofFailed
.Closes: #1169
Describe the changes you've made
pkg/util.go
to handle cases where the returned HTTP response is null, to return a validmodels.HttpResp
to make sure that this case can be accurately classified as Failed inpkg/service/test/test.go
when compared with the actual response that needed to be returned.pkg/service/test/test.go
to check if response is nil before doing an early return without runningtestHttp
.Type of change
Please let us know if any test cases are added
NA
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)NA
Checklist:
Screenshots (if any)
NA