Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modified return of nil response for HTTP Connection Error #1174

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

ChinmayaSharma-hue
Copy link
Contributor

Related Issue

When port is changed in the test case after keploy record is run, the keploy test produces a report which shows that the status is Running instead of Failed.

Closes: #1169

Describe the changes you've made

  • A small code change in pkg/util.go to handle cases where the returned HTTP response is null, to return a valid models.HttpResp to make sure that this case can be accurately classified as Failed in pkg/service/test/test.go when compared with the actual response that needed to be returned.
  • A condition addition in an if block in pkg/service/test/test.go to check if response is nil before doing an early return without running testHttp.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

NA

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

NA

Signed-off-by: Chinmay <chinmaysharma1020@gmail.com>
Copy link

github-actions bot commented Dec 5, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

Copy link

sweep-ai bot commented Dec 5, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@re-Tick
Copy link
Contributor

re-Tick commented Dec 6, 2023

Please sign the CLA assistant by commenting the stmt:
"I have read the CLA Document and I hereby sign the CLA"

@ChinmayaSharma-hue
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@re-Tick re-Tick merged commit 4f52122 into keploy:main Dec 13, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Running test report for the failed api request in test mode
3 participants