Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: added support for relative volume mounts in docker compose #1186

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

amoghumesh
Copy link
Contributor

Related Issue

  • When relative file paths are present in docker compose file of the application, application is mounted at /files to the keploy container so relative paths are resolved to the path inside keploy container but they should actually be resolved to host file system paths.

Closes: #1049

Describe the changes you've made

  • Created three new functions in pkg/clients/docker/docker_client.go:

    • CheckBindMounts: Returns true if any relative paths are being used in volumes in compose file
    • ReplaceRelativePaths: Replaces relative paths with absolute path with respect to host filesystem which it obtains by calling GetHostWorkingDirectory. Creates a new kdocker-compose.yml file with the changes.
    • GetHostWorkingDirectory: Inspects keploy-v2 docker container and gets the mount path for /files. This is the application directory in the host file system.
  • Added an if block in pkg/hooks/launcher.go which runs for docker compose related commands and checks if relative file paths are present and replaces them.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

NA

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

NA

Copy link

github-actions bot commented Dec 11, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

Copy link

sweep-ai bot commented Dec 11, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@amoghumesh
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@amoghumesh
Copy link
Contributor Author

recheck

Signed-off-by: Amogh Umesh <amoghumesh02@gmail.com>
Signed-off-by: Amogh Umesh <amoghumesh02@gmail.com>
Copy link
Member

@gouravkrosx gouravkrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gouravkrosx gouravkrosx merged commit fa1725d into keploy:main Dec 11, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants