Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Add support for arm64 docker images #120

Merged
merged 8 commits into from
Apr 19, 2022

Conversation

ditsuke
Copy link
Contributor

@ditsuke ditsuke commented Apr 19, 2022

Related Issue

  • Info about Issue or bug

Closes: #118

Describe the changes you've made

This PR adds arm64 docker image builds to our CI pipeline.

Here's a sample run on my repo: ditsuke/keploy/runs/ ....
And the docker image build: docker.io:ditsuke/keploy.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

None

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

None

@ditsuke ditsuke marked this pull request as draft April 19, 2022 13:10
@nehagup nehagup requested a review from slayerjain April 19, 2022 13:34
@slayerjain slayerjain marked this pull request as ready for review April 19, 2022 13:59
Copy link
Member

@slayerjain slayerjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Great work @ditsuke ! Thanks for the PR! ❤️

@slayerjain slayerjain merged commit d4d40c1 into keploy:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: add support for arm64 docker images
2 participants