feat: Added extra fields for sentry #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Apply Sweep Rules to your PR?
|
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
cmd/root.go
Outdated
| @@ -124,8 +127,35 @@ func modifyToSentryLogger(log *zap.Logger, client *sentry.Client) *zap.Logger { | |||
| } | |||
|
|
|||
| log = zapsentry.AttachCoreToLogger(core, log) | |||
|
|
|||
| return log.With(zapsentry.NewScope()) | |||
| kernelVersion := "Not linux" | |||
There was a problem hiding this comment.
What is the significance of this value..?
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
cmd/record.go
Outdated
| } else { | ||
| fmt.Println("Example usage:\n", cmd.Example) | ||
| } | ||
| fmt.Println("Error: missing required -c flag or appCmd in config file") |
There was a problem hiding this comment.
Please correct the indentation.
cmd/record.go
Outdated
| @@ -227,6 +233,9 @@ func (r *Record) GetCmd() *cobra.Command { | |||
|
|
|||
| recordCmd.Flags().String("config-path", ".", "Path to the local directory where keploy configuration file is stored") | |||
|
|
|||
| recordCmd.Flags().Bool("enableTele", true, "Switch for telemetry") | |||
| _ = recordCmd.Flags().MarkHidden("enableTele") | |||
There was a problem hiding this comment.
I think this assignment is optional. Please remove assignment if it is optional.
cmd/root.go
Outdated
| } | ||
| } | ||
| sentry.ConfigureScope(func(scope *sentry.Scope) { | ||
| scope.SetTag("Keploy Version", utils.KeployVersion) |
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Currently there were very few fields being sent to sentry which was making it hard to debug
Describe the changes you've made
Add 4 new fields to all the events being sent by sentry using the zap logger
Type of change
Checklist: