Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(publish-docker): Remove QEMU setup #121

Conversation

ditsuke
Copy link
Contributor

@ditsuke ditsuke commented Apr 19, 2022

Related Issue

  • Info about Issue or bug

Closes: #118

Describe the changes you've made

After some investigation, @slayerjain and I concluded that QEMU is not required by our multiarch build. This PR removes the setup-qemu step from the docker-publish workflow.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

None.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

N/A

@nehagup nehagup requested a review from slayerjain April 19, 2022 16:28
On investigating, @slayerjain and I found that the
GOARCH flags were not necessary.
On investigation prompted by @slayerjain, we found that
QEMU is not required for our multiarch build.
@ditsuke ditsuke changed the title build(docker): Add missing GOARCH env for multiarch go builds ci(publish-docker): Remove QEMU setup Apr 19, 2022
Copy link
Member

@slayerjain slayerjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @ditsuke. thanks for going the extra mile to investigate the need for qemu and some flags.

@slayerjain slayerjain merged commit 1437655 into keploy:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: add support for arm64 docker images
2 participants