Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: remove unused files #1218

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

shubham14bajpai
Copy link
Contributor

Related Issue

  • Info about Issue or bug

Closes: #1215

Describe the changes you've made

Observed there were two packages replay and plugin with no code in the files. I see the replay package is already removed. This MR cleans up the plugin package.

❯ find * -type f -name "*.go" -exec sh -c 'lines=$(wc -l < "$1"); if [ $lines -lt 5 ]; then echo "File: $1, Lines: $lines"; fi' _ {} \;

File: cmd/replay.go, Lines:        1
File: pkg/plugin/shared/test.go, Lines:        1
File: pkg/plugin/plugin.go, Lines:        1

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Copy link

github-actions bot commented Dec 18, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Signed-off-by: Shubham Bajpai <shbajpai@vmware.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

Copy link

sweep-ai bot commented Dec 18, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@shubham14bajpai
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@shivamsouravjha shivamsouravjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivamsouravjha shivamsouravjha merged commit 35116f5 into keploy:main Dec 19, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor]: remove unused files
2 participants