-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: added golint in pipeline #1223
Conversation
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Apply Sweep Rules to your PR?
|
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
8d0ed65
to
80b617e
Compare
@shivamsouravjha PTAL |
seems to have some error as it doesn't run on this PR |
@shivamsouravjha, |
to be clear the expectation is that once a PR is raise this should check for the code changes in the PR and be able to detect any changes that has lint issues |
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
@shivamsouravjha, Just for demo I ran the linter on the whole codebase. As you can see now the test is failing. Here is the log |
Will it possible to not involve in previous errors ? as because of it folks won't be able to merge any PR. |
@shivamsouravjha # Optional: show only new issues if it's a pull request. The default value is `false`.
# only-new-issues: true |
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
@shivamsouravjha PTAL |
Tried running this in pipeline got this errorf https://github.com/keploy/samples-go/actions/runs/7538153673/job/20518222700?pr=91 |
@shivamsouravjha, Thanks for the reply. The error only occurs for samples-go because of this reason. I think there will be no errors if the pipeline is ran in Keploy repo. I've opened a PR for modified version of the golint pipeline for samples-go which is in draft. I will let you know once it is working fine. |
@officialasishkumar I've added @PranshuSrivastava as reviewer as well. |
@shivamsouravjha PTAL |
I think its good start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
feature: add golint in pipeline
Closes: #1216
Describe the changes you've made
.github/workflow
to run only on the changes made in the PR..golangci.yml
Type of change
Feature
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)NA
Checklist:
Screenshots (if any)