Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: logs in record and test commands #1228

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

ananupam
Copy link
Contributor

@ananupam ananupam commented Dec 20, 2023

Related Issue

-refactored logs from print to logger

Closes: #1202

Describe the changes you've made

Updated the codebase to utilize logging methods for generating logs instead of relying on print statements.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated

|
image
|
image
|

Signed-off-by: ananupam <2019024@iiitdmj.ac.in>
Copy link

github-actions bot commented Dec 20, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

Copy link

sweep-ai bot commented Dec 20, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@ananupam
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

cmd/record.go Outdated Show resolved Hide resolved
Signed-off-by: ananupam <2019024@iiitdmj.ac.in>
Copy link
Member

@gouravkrosx gouravkrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivamsouravjha shivamsouravjha merged commit 603759c into keploy:main Dec 20, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: refactor delay flag log
3 participants