Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run cmd using the shell's -c flag #1273

Merged
merged 10 commits into from
Jan 1, 2024
Merged

fix: run cmd using the shell's -c flag #1273

merged 10 commits into from
Jan 1, 2024

Conversation

re-Tick
Copy link
Contributor

@re-Tick re-Tick commented Dec 31, 2023

Related Issue

  • Fails for multiple commands passed in the -c flag

Closes: #1272

Describe the changes you've made

In place of splitting the app command and passing to the os.exec package, sh -c is used to execute the app command. This will help in executing multiple shell commands for starting the user application. Now, shell script can be passed to start the user app.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

the decode function is not able to distinguish the closing braces of the string json and sectionSingle, so used the prefix and suffix in place of regex to extract the document correctly

Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
the sh shell provides a flag to run multiple commands from a single shell cmd. So using this we will be able to use the parsing of script cmds of shell

Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
Copy link

sweep-ai bot commented Dec 31, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@Sarthak160 Sarthak160 merged commit df2e195 into main Jan 1, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: failed to run script commands in the -c flag
2 participants