-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mongo scram #1302
Fix mongo scram #1302
Conversation
the decode function is not able to distinguish the closing braces of the string json and sectionSingle, so used the prefix and suffix in place of regex to extract the document correctly Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
Updates the extraction of client nonce from the saslStart request. And updates the conversationId in the response of saslStart and request of saslContinue Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
Apply Sweep Rules to your PR?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments. Most of the comments are questions for my understanding.
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
* add coverage flag to implement serve Signed-off-by: EraKin575 <tejaskumar574@gmail.com> * removed serve.go and moved functionality to test Signed-off-by: EraKin575 <tejaskumar574@gmail.com> * changed workflow according to new changes Signed-off-by: EraKin575 <tejaskumar574@gmail.com> * changed workflow according to new changes Signed-off-by: EraKin575 <tejaskumar574@gmail.com> --------- Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think there are few other changes added in the PR from other's commit. |
Yes they were made to merge to main branch. but there is some issue with the main branch. |
Related Issue
Closes: #1301
Describe the changes you've made
Updates the extraction of client nonce from the saslStart request. And updates the conversationId in the response of saslStart and request of saslContinue.
For a client nonce in r like this:
n,,n=svoc-owner,r=9'sji{=${C"StM|SZWM1>Vpk
, the current extractClientNonce fails due to the presence of=
char in the nonce. This is fixed by usingstrings.TrimPrefix(part, "r=")
in place of thestrings.Split(part, "=")[1]
of the extractClientNonce.And the
saslContinue
is failing because we are returning the same conversationId in the response ofsaslStart
due to which the key collision occurs forauthMessageMap
since, the key is used conversationId to get the authMessage for generating the server signature for response of saslContinue. So, the conversationId is updated for the response of saslStart and conversationId is extracted from the saslContinue request to fetch the authMessage from the authMessageMap.Type of change
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)A clear and concise description of it.
Checklist: