chore: logging an example when generate-config fails #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Apply Sweep Rules to your PR?
|
|
will review by EOD |
|
I think few other changes have got added in the PR. Please check once mainly in go.mod and go.sum file. |
| results, err := yaml.Marshal(node.Content[0]) | ||
| if err != nil { | ||
| g.logger.Fatal("Failed to marshal the config", zap.Error(err)) | ||
| } | ||
|
|
||
| err = os.WriteFile(filePath, results, os.ModePerm) | ||
| finalOutput := append(results, []byte(utils.ConfigGuide)...) |
There was a problem hiding this comment.
Is this tested that we are getting same config file as before..?
There was a problem hiding this comment.
yes, attaching screenshot for reference
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Improving the logging of Keploy when it fails due to the keploy config file.
Fixes: #1259
Describe the changes you've made
Added a log in record and test mode where we log an example to use the keploy-config file, whenever keploy fails because of it.
Type of change
Checklist:
Screenshots (if any)