-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added Keploy Update to CLI #1325
Conversation
Signed-off-by: Akash <akashsingh2210670@gmail.com>
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Signed-off-by: Akash <akashsingh2210670@gmail.com>
I have read the CLA Document and I hereby sign the CLA |
@Akash-Singh04 If there is a way to get the changelog for the new version, it would be great to display it after updating the binary. |
Also, if the api endpoint used to fetch the version is down or unresponsive, will the keploy execution hang waiting for a response from the endpoint ? |
you can transfer the redundant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address the review comments
Understood! Working on the proposed changes! |
Signed-off-by: Akash <akashsingh2210670@gmail.com>
Signed-off-by: Akash <akashsingh2210670@gmail.com>
… into updatecommand
since the utils/utils.go package is on https://pkg.go.dev/go.keploy.io/server/utils , i am unable to modify that package into having the getGithubUpdateRelease() function. Am i missing out on something here? If so kindly let me know how do i update the utils package to now include this new function |
@AkashKumar7902 Updated the PR, kindly have a look and revert |
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
the changelog returned by the github api is in the form of markdown. we can't display raw markdown. convert into a pretty format |
Will make the necessary changes and revert |
Signed-off-by: Akash <akashsingh2210670@gmail.com>
Signed-off-by: Akash <akashsingh2210670@gmail.com>
@charankamarapu @AkashKumar7902 How are we planning to implement the update message? As @charankamarapu pointed out, it will cause a 2-3s delay everytime a keploy command is run as it is making an HTTP request. An alternative i can suggest is to instead have the message pop up at the end of command execution, hence not effecting the user experience. Kindly let me know the implementation of this, alternatively we can seggregate the update message into a different issue to reflect upon it further |
… into updatecommand
Signed-off-by: Akash <akashsingh2210670@gmail.com>
Signed-off-by: Akash <akashsingh2210670@gmail.com>
Signed-off-by: Akash <akashsingh2210670@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments
Signed-off-by: Akash <akashsingh2210670@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments
Signed-off-by: Akash <akashsingh2210670@gmail.com>
Signed-off-by: Akash <akashsingh2210670@gmail.com>
Signed-off-by: Akash <akashsingh2210670@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comment everything else looks good to me.
Signed-off-by: Akash <akashsingh2210670@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
Related Issue
Resolves: #1303
Describe the changes you've made
The updates include:
Addition of Update Command
Addition of notification for new update
Type of change
Please let us know if any test cases are added
NIL
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
A clear and concise description of it.
Checklist:
Screenshots (if any)