Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pg-parser): ignore deletion of startup request mocks during match #1341

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

Sarthak160
Copy link
Member

Related Issue

  • Info about Issue or bug

Closes: #[issue number that will be closed through this PR]

Describe the changes you've made

Some applications are making more connections with Postgres during test mode than it did during record mode. So there are also more auth requests from the application during test mode, but we didn't have sufficient auth packets - which leads to auth failures in some requests.

Why did this happen?

Since the application is able to execute much faster during testmode, it tries to increase the connection pool to handle higher request throughput. This seems to be normal application behaviour for psycog3
Fix: We are making database connection related properties like authentication re-useable to handle cases where more connections are created during test mode.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: Sarthak160 <rocksarthak45@gmail.com>
Signed-off-by: Sarthak160 <rocksarthak45@gmail.com>
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@Sarthak160 Sarthak160 merged commit be573eb into keploy:main Jan 11, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants