-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: HTTP handling for partial header reception #1347
Merged
gouravkrosx
merged 5 commits into
keploy:main
from
gouravkrosx:httpParser_partial_header
Jan 17, 2024
Merged
fix: HTTP handling for partial header reception #1347
gouravkrosx
merged 5 commits into
keploy:main
from
gouravkrosx:httpParser_partial_header
Jan 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
gouravkrosx
force-pushed
the
httpParser_partial_header
branch
from
January 12, 2024 10:51
71b043b
to
5750435
Compare
Apply Sweep Rules to your PR?
This is an automated message generated by Sweep AI. |
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
will review by EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments. Rest of the things looks good to me.
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
charankamarapu
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes: #1346
Describe the changes you've made
Our proxy operates as a TCP server rather than an HTTP server, making it possible for HTTP headers not to arrive in the first chunk. Our HTTP parser observed headers arriving in multiple chunks due to TCP fragmentation based on chunk length, especially when the sender buffer is smaller. I've implemented a fix to handle these header chunks until complete headers are received.
I've refactored error handling, identifying cases where certain errors need to be propagated to the caller function.
Addressed an issue with the HTTP mock response headers, where two content-length values were being received. Previously, the code used the
add
function, but it should use theset
function ofHeaders
. This has been corrected.Type of change
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)NA
Checklist:
Screenshots (if any)