Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HTTP handling for partial header reception #1347

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

gouravkrosx
Copy link
Member

Related Issue

  • Keploy HttpParser fails to handle when HTTP headers also come in chunks

Closes: #1346

Describe the changes you've made

  • Our proxy operates as a TCP server rather than an HTTP server, making it possible for HTTP headers not to arrive in the first chunk. Our HTTP parser observed headers arriving in multiple chunks due to TCP fragmentation based on chunk length, especially when the sender buffer is smaller. I've implemented a fix to handle these header chunks until complete headers are received.

  • I've refactored error handling, identifying cases where certain errors need to be propagated to the caller function.

  • Addressed an issue with the HTTP mock response headers, where two content-length values were being received. Previously, the code used the add function, but it should use the set function of Headers. This has been corrected.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

  • I've tested the changes with java and Golang applications.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Copy link

sweep-ai bot commented Jan 12, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
@charankamarapu
Copy link
Member

will review by EOD

Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments. Rest of the things looks good to me.

pkg/proxy/integrations/httpparser/httpparser.go Outdated Show resolved Hide resolved
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@gouravkrosx gouravkrosx merged commit f5d3aa5 into keploy:main Jan 17, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: keploy fails to Handle HTTP Headers if Not Received in First Chunk
2 participants