Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated io/ioutil package #1350

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

nnnkkk7
Copy link
Contributor

@nnnkkk7 nnnkkk7 commented Jan 14, 2024

Related Issue

  • Info about Issue or bug

Closes: #1587

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

I replaced deprecated io/ioutil package with io and os package.
https://pkg.go.dev/io/ioutil

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Copy link

github-actions bot commented Jan 14, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@nnnkkk7
Copy link
Contributor Author

nnnkkk7 commented Jan 14, 2024

I have read the CLA Document and I hereby sign the CLA

@nnnkkk7
Copy link
Contributor Author

nnnkkk7 commented Jan 14, 2024

recheck

@shivamsouravjha
Copy link
Contributor

shivamsouravjha commented Jan 31, 2024

Hey @nnnkkk7 can you open an issue for this PR and link the PR to issue?

Also take the pull as there are merge conflicts rest LGTM

Copy link
Contributor

@shivamsouravjha shivamsouravjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the merge conflict,rest LGTM

Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>
@nnnkkk7
Copy link
Contributor Author

nnnkkk7 commented Feb 17, 2024

@shivamsouravjha
thank you!
I created this issue!
#1587

Copy link
Contributor

@shivamsouravjha shivamsouravjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivamsouravjha shivamsouravjha merged commit 76cea85 into keploy:main Feb 17, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: io/ioutil package is deprecated
2 participants