Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing requests and their timestamps #1405

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

gouravkrosx
Copy link
Member

@gouravkrosx gouravkrosx commented Jan 20, 2024

Related Issue

  • Some requests were not successfully recorded because the user's side experienced a buffer size of 0. Consequently, this issue led to the absence of timestamps for certain requests and responses.

Closes: #1406

Describe the changes you've made

  • The problem originated from the eBPF side, where the "ishttpconnection" function failed to validate requests of the OPTIONS type. Initially, the function only checked for certain HTTP request methods (POST, PUT, GET, DELETE, PATCH, and HEAD). I resolved this by adding checks for OPTIONS, TRACE, and CONNECT. The lack of validation for OPTIONS requests caused the failure to trigger the request data event, resulting in responses with a 0 buffer size.
  • Addressing the aforementioned issue also resolved the problem with timestamps, as it involved correcting the order of the arrays for request and response timestamps.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Copy link
Member

@slayerjain slayerjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slayerjain slayerjain merged commit acd392f into keploy:fix-http-ingress Jan 20, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants