Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:setting time stamp for response only after verified response #1433

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

shivamsouravjha
Copy link
Contributor

@shivamsouravjha shivamsouravjha commented Jan 25, 2024

Related Issue

Describe the changes you've made

Because of maintaining an array of mock and picking the first element of the array we were unable to get certain mock files as a result of which connection would end and test cases would fail.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

image

Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but Can you explain why is the last chuck timestamp approach is not implemented? Like maintaining an array and instead of first timestamp taking the last one.

@shivamsouravjha
Copy link
Contributor Author

shivamsouravjha commented Jan 29, 2024

Seems like there is only one element in the array, I tried with the above approach yet it didn't work , seems there has to be some more debug needed to use that approach, as of now this PR will fix the current ongoing issue.

@shivamsouravjha shivamsouravjha force-pushed the shivam/mongofix branch 2 times, most recently from 1f62665 to 8f5691d Compare January 29, 2024 11:36
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@charankamarapu charankamarapu merged commit 76cc78b into main Jan 29, 2024
13 checks passed
@charankamarapu charankamarapu deleted the shivam/mongofix branch January 29, 2024 11:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Gin-mongo throwing error in Test mode in POST calls
2 participants