Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: call next for passthrough post #1455

Merged
merged 6 commits into from
Feb 5, 2024
Merged

refactor: call next for passthrough post #1455

merged 6 commits into from
Feb 5, 2024

Conversation

shivamsouravjha
Copy link
Contributor

@shivamsouravjha shivamsouravjha commented Jan 30, 2024

Related Issue

  • race condition while using callNext

Closes: #1466

Describe the changes you've made

  • CustomConn uses ReadBytes which uses c.r.Read(p) which access the first element of array.
  • Added mutex as to ensure no race condition occurs to avoid buffer read concurrently.
  • Added check of eof
  • update CI to ensure this case is tested as well

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

@shivamsouravjha shivamsouravjha force-pushed the shivam/portFIx branch 2 times, most recently from f9db202 to 9c75ef6 Compare January 31, 2024 13:56
Copy link
Member

@gouravkrosx gouravkrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gouravkrosx gouravkrosx merged commit 7a84978 into main Feb 5, 2024
13 checks passed
@gouravkrosx gouravkrosx deleted the shivam/portFIx branch February 5, 2024 07:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: index out of range when doing pass through port
2 participants