Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:function name and checks #1475

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

shivamsouravjha
Copy link
Contributor

@shivamsouravjha shivamsouravjha commented Feb 1, 2024

Related Issue

  • Info about Issue or bug

Closes: #1463

Describe the changes you've made

Add checks to ensure user application isn't terminated before proceeding to stop the server

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Uploading image.png…

Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@@ -198,10 +198,18 @@ func (h *Hook) GetTcsMocks() ([]*models.Mock, error) {
return tcsMocks, nil
}

func (h *Hook) IsUsrAppTerminateInitiated() bool {
func (h *Hook) IsUserAppTerminateInitiated() bool {
h.mutex.Lock()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to use to different mutex object. Same mutex is used for appending mocks. This mutex may collide with appending mocks mutex.

@charankamarapu charankamarapu merged commit ab4e156 into main Feb 5, 2024
13 checks passed
@charankamarapu charankamarapu deleted the shivam/dockerError branch February 5, 2024 06:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Failed to stop/remove the docker container
2 participants