-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: merged colima alias into docker and removed unnecessary sudo #1476
Conversation
…cker commands Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
@PranshuSrivastava I tried on macOS and when the docker daemon is stopped, I get some logs. Please add a log like "Keploy only supports intercepting and replaying docker containers on macOS, and requires Docker to be installed and running"
|
…to update-oneclick
…to update-oneclick
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
08b8105
to
dbb4d9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
Currently keploy has different alias for colima and docker for mac which can be merged together. We also need to remove the unnecessary use of sudo in the script.
Closes: #1470
Describe the changes you've made
Merged colima and docker alias into one and also added conditions for using sudo in the alias.
Type of change
Checklist: