Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merged colima alias into docker and removed unnecessary sudo #1476

Merged
merged 9 commits into from
Feb 12, 2024

Conversation

PranshuSrivastava
Copy link
Member

@PranshuSrivastava PranshuSrivastava commented Feb 1, 2024

Related Issue

Currently keploy has different alias for colima and docker for mac which can be merged together. We also need to remove the unnecessary use of sudo in the script.

Closes: #1470

Describe the changes you've made

Merged colima and docker alias into one and also added conditions for using sudo in the alias.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

…cker commands

Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
@slayerjain
Copy link
Member

@PranshuSrivastava I tried on macOS and when the docker daemon is stopped, I get some logs. Please add a log like "Keploy only supports intercepting and replaying docker containers on macOS, and requires Docker to be installed and running"

curl -O https://raw.githubusercontent.com/PranshuSrivastava/keploy/update-oneclick/keploy.sh && source keploy.sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6389  100  6389    0     0  11146      0 --:--:-- --:--:-- --:--:-- 11130
Cannot connect to the Docker daemon at unix:///Users/shubham/.docker/run/docker.sock. Is the docker daemon running?
Cannot connect to the Docker daemon at unix:///Users/shubham/.docker/run/docker.sock. Is the docker daemon running?
Cannot connect to the Docker daemon at unix:///Users/shubham/.docker/run/docker.sock. Is the docker daemon running?
docker: Cannot connect to the Docker daemon at unix:///Users/shubham/.docker/run/docker.sock. Is the docker daemon running?.
See 'docker run --help'.

Copy link
Member

@gouravkrosx gouravkrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gouravkrosx gouravkrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gouravkrosx gouravkrosx merged commit 648f677 into keploy:main Feb 12, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Update the docker installation script
3 participants