Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some fields not being set in test report #1499

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

PranshuSrivastava
Copy link
Member

Related Issue

Some fields were missing information in the test reports and that was cause confusion for the users.

Closes: #1471

Describe the changes you've made

Realised that all not all fields were being passed to the setresult function that was supposed to write the result to the yaml file and that is why the reports had incomplete information. Added all the fields to it so that it works correctly and also removed unnecessary fields.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PranshuSrivastava and others added 4 commits February 4, 2024 19:53
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Copy link
Member

@Sarthak160 Sarthak160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Sarthak160 Sarthak160 merged commit f65b05c into keploy:main Feb 13, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Test reports have incomplete/missing information
2 participants