-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: diff viewer of response #1512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the diff in the cli isn't showing certain fields which should be shown. This is because when array order is changed it will be treated as struct type of Same issue has been raised in this repo as well yudai/gojsondiff#39. In the above issue the response was this:-
and this is the difference shown by the tool. The field
is missing in the diff viewer. |
Related Issue
Closes: #1518
Describe the changes you've made
Refactored the function.
Used better name for variables and checked for maps as well to show difference in objects.
Type of change
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)A clear and concise description of it.
Checklist:
Screenshots (if any)