Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: hide complete test summary in case of app not running #1590

Merged

Conversation

AhmedLotfy02
Copy link
Contributor

Related Issue

  • Hide complete test summary in case of app not running

Closes: #1577

Describe the changes you've made

-If there are testcases then the test summary and coverage opportunity will appear otherwise not.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

  • I tested it with and without testcases.
    Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: AhmedLotfy02 <ahmadlotfygamersfield@gmail.com>
@AhmedLotfy02
Copy link
Contributor Author

I wanted to make a make the test summary runs at the end of the Test function but the error of permissions won't be caught there as it's in cmd/test.go so can i make a function in utils that prints the test summary at the end of cmd/test.go
another solution is to make the file existence check inside service/test/test.go at the end of the function and use defer to print the test summary at the end of Test function

Signed-off-by: AhmedLotfy02 <ahmadlotfygamersfield@gmail.com>
Signed-off-by: AhmedLotfy02 <ahmadlotfygamersfield@gmail.com>
Copy link
Contributor

@shivamsouravjha shivamsouravjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shivamsouravjha shivamsouravjha merged commit 61b9997 into keploy:main Feb 19, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: hide complete test summary in case of application not run
2 participants