-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix: Keploy test runs succesfully with no test cases #1597
Conversation
Signed-off-by: Akash <akashsingh2210670@gmail.com>
@charankamarapu Let me know if this implementation is apt! |
Please update the branch . And also have the many number of test-set then how are you going to approach this . Lets say I have 10 test-sets in which only one is empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are no file changes
Signed-off-by: Akash Singh <akashsingh2210670@gmail.com>
@charankamarapu After the v2 refactoring, i have added warnings so that the user is warned about missing keploy folder, and if only a single test set is empty, the execution of other test sets continues normally whilst informing the user of the missing test set. Please review the PR and refer to the updated pr description for the screenshots |
Signed-off-by: Akash Singh <akashsingh2210670@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments
Signed-off-by: Akash Singh <akashsingh2210670@gmail.com>
…into testcmdbug
@charankamarapu Your requested changes have been made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments
cli/provider/cmd.go
Outdated
if _, err := os.Stat(c.cfg.Path); os.IsNotExist(err) { | ||
recordCmd := models.HighlightGrayString("keploy record") | ||
errMsg := fmt.Sprintf("Keploy folder not found. Please record testcases using %s command", recordCmd) | ||
utils.LogError(c.logger, err, errMsg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey just saw the screenshot and I think the error shouldn't include stat error and it will be good if error is "no test-sets found" rather than "no keploy folder" because keploy folder has no usecase to user but test-sets does. Please update the screenshots after this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored and updated screenshot no.3
Signed-off-by: Akash Singh <akashsingh2210670@gmail.com>
@charankamarapu Your requested changes have been made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
-Bug Fix
Closes: #1270 #1750
Describe the changes you've made
keploy test
informs the user that no test cases were found instead of completing the test successfully.keploy test
runs normally and informs user of the empty test cases.keploy test
informs user of missing Keploy Folder and exits gracefully.Type of change
Please let us know if any test cases are added
NIL
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)NIL
Checklist:
Screenshots (if any)