Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds test filter to the serve to generate code coverage #1612

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

re-Tick
Copy link
Contributor

@re-Tick re-Tick commented Feb 23, 2024

Related Issue

  • filter to run specific test-set/testcases do not work for code coverages

Closes: #1611

Describe the changes you've made

Returns filtered test sets to the unit test frameworks and passes filtered testcases to the RunTestSets of test service

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Tested the changes with junit test to capture code coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
Copy link
Member

@gouravkrosx gouravkrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gouravkrosx gouravkrosx merged commit 1e6183b into main Feb 23, 2024
14 checks passed
@gouravkrosx gouravkrosx deleted the fix-testfilter branch February 23, 2024 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: filter to run specific test-set/testcases do not work for code coverages
2 participants