Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates the exec cmd to start user application #1643

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Conversation

re-Tick
Copy link
Contributor

@re-Tick re-Tick commented Mar 4, 2024

Related Issue

  • user env variables are of the root to start user application

Closes: #1634

Describe the changes you've made

Run the user application in a shell which is started by the user shell by using the sudo -u <username> sh -c cmd to preserve the user env variables.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Tested with the env cmd to check the user env variables are correctly passed or not.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

re-Tick and others added 4 commits March 1, 2024 15:19
Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
…e user env variables

Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
@re-Tick re-Tick changed the title fix: updates the fix: updates the exec cmd to start user application Mar 4, 2024
Copy link
Member

@Sarthak160 Sarthak160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@re-Tick re-Tick merged commit c389dbf into main Mar 4, 2024
14 checks passed
@re-Tick re-Tick deleted the fix-user-cmd branch March 4, 2024 10:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Keploy Javascript SDK]: Issue with env variables when running application
2 participants