-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Added check for detach mode #1647
Conversation
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@charankamarapu Please review the changes. |
…into check-detach-mode
Hey @Yaxhveer we have refactored the main code base. But the docker related testing is not yet done. We will notify you once that is done and then we continue with the PR. |
…detach-mode Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@charankamarapu PR is updated according to the refactored codebase. Kindly review the PR |
Changes look fine please add the screenshot of the result. |
@charankamarapu cmd: |
LGTM, Merging the PR into main. |
Related Issue
Closes: #1645
Describe the changes you've made
Added check for detach mode in docker command.
Type of change
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)A clear and concise description of it.
Checklist:
Screenshots (if any)