Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Added check for detach mode #1647

Merged
merged 13 commits into from
Apr 15, 2024
Merged

Conversation

Yaxhveer
Copy link
Contributor

@Yaxhveer Yaxhveer commented Mar 4, 2024

Related Issue

  • Info about Issue or bug

Closes: #1645

Describe the changes you've made

Added check for detach mode in docker command.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@Yaxhveer
Copy link
Contributor Author

Yaxhveer commented Mar 4, 2024

@charankamarapu Please review the changes.

@charankamarapu
Copy link
Member

Hey @Yaxhveer we have refactored the main code base. But the docker related testing is not yet done. We will notify you once that is done and then we continue with the PR.

Yaxhveer and others added 4 commits March 27, 2024 20:45
…detach-mode

Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@Yaxhveer
Copy link
Contributor Author

@charankamarapu PR is updated according to the refactored codebase. Kindly review the PR

@charankamarapu charankamarapu self-requested a review April 15, 2024 08:22
@charankamarapu
Copy link
Member

Changes look fine please add the screenshot of the result.

@Yaxhveer
Copy link
Contributor Author

Yaxhveer commented Apr 15, 2024

@charankamarapu cmd: keployV2 record -c "docker compose up -d" --containerName "ginMongoApp"

image

@re-Tick
Copy link
Contributor

re-Tick commented Apr 15, 2024

LGTM, Merging the PR into main.

@re-Tick re-Tick merged commit 9012fca into keploy:main Apr 15, 2024
13 of 14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Check for detach mode in docker command
3 participants