Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect dns calls by configuring nsswitch config file in linux #1678

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

re-Tick
Copy link
Contributor

@re-Tick re-Tick commented Mar 11, 2024

Related Issue

  • Test mode fails for an API maing an external https call for fedora-39.

Closes: #1679

Describe the changes you've made

Linux distros like fedora uses systemd-resolve for dns resolution which makes unix socket with the application due to which keploy is not able to redirect them to proxy in test mode. This results in test failure. This is handled by editing the nsswitch.conf of /etc in linux to not use resolve in test mode

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

re-Tick and others added 3 commits March 11, 2024 15:01
linux distros like fedora uses systemd-resolve for dns resolution which makes unix socket with the application due to which keploy is not able to redirect them to proxy in test mode. This results in test failure. This is handled by editing the nsswitch.conf of /etc in linux to not use resolve in test mode

Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
@Sarthak160 Sarthak160 merged commit 7fe9bc0 into main Mar 11, 2024
14 checks passed
@Sarthak160 Sarthak160 deleted the fix-dns branch March 11, 2024 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: test fails in fedora for node app with HTTPS external dependency
2 participants