Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor keploy codebase #1684

Merged
merged 190 commits into from
Mar 13, 2024
Merged

chore: refactor keploy codebase #1684

merged 190 commits into from
Mar 13, 2024

Conversation

slayerjain
Copy link
Member

@slayerjain slayerjain commented Mar 13, 2024

Features:

  1. Implemented a separation of tightly copuled components such as hooks, proxies, databases, applications, and command-line interfaces, by establishing well-defined interfaces. This architectural refinement enhances modularity and fosters a more maintainable codebase.

  2. Enhanced the CLI for improved modularity and extendibility, capitalised on the advantage of integration of Viper and Cobra libraries for combination of flags and config files.

  3. Incorporated context and context cancellation mechanisms extensively across operations prone to delays, blockages, or those executed in goroutines. This done for automatic, proper shutdown of keploy.

  4. Transitioned Docker-related operations away from reliance on Docker CLI to Docker sdk which decreases the usage of users docker cli which is a risk.

  5. Moved away from the use of exec calls for external processes, favouring the utilisation of native libraries instead. This decision minimises security risks and dependencies, leading to a cleaner, more self-contained application architecture.

  6. Refactored the GraphQL server implementation for the replay feature, which makes the graphql server light weight and better code readability and architecture

slayerjain and others added 30 commits February 9, 2024 22:33
Signed-off-by: slayerjain <shubhamkjain@outlook.com>
Signed-off-by: Shubham Jain <shubhamkjain@outlook.com>
Signed-off-by: Shubham Jain <shubhamkjain@outlook.com>
Signed-off-by: Shubham Jain <shubhamkjain@outlook.com>
Signed-off-by: Shubham Jain <shubhamkjain@outlook.com>
Signed-off-by: Shubham Jain <shubhamkjain@outlook.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: Shubham Jain <shubhamkjain@outlook.com>
Signed-off-by: Shubham Jain <shubhamkjain@outlook.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: Shubham Jain <shubhamkjain@outlook.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: Shubham Jain <shubhamkjain@outlook.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
charankamarapu and others added 25 commits March 11, 2024 10:21
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
@charankamarapu charankamarapu self-requested a review March 13, 2024 08:17
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slayerjain slayerjain merged commit 93d2476 into main Mar 13, 2024
4 of 13 checks passed
@slayerjain slayerjain deleted the keploy-v2-refactor branch March 13, 2024 08:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants