Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mock re-record functionality in v2 #1704

Merged
merged 45 commits into from
May 6, 2024

Conversation

EraKin575
Copy link
Contributor

@EraKin575 EraKin575 commented Mar 18, 2024

Related Issue

  • Info about Issue or bug

Closes: #1468

docs link

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
@EraKin575
Copy link
Contributor Author

@Sarthak160 please review

Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
EraKin575 and others added 13 commits March 21, 2024 14:12
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
@Sarthak160
Copy link
Member

Please resolve the linting issues. @EraKin575

EraKin575 and others added 11 commits April 9, 2024 02:16
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
@Sarthak160 Sarthak160 changed the title added re-record in v2 feat: added mock re-record in v2 Apr 27, 2024
@Sarthak160 Sarthak160 changed the title feat: added mock re-record in v2 feat: add mock re-record functionality in v2 Apr 27, 2024
Sarthak160 and others added 6 commits April 27, 2024 14:30
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: Sarthak160 <rocksarthak45@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
pkg/service/record/record.go Outdated Show resolved Hide resolved
pkg/service/record/record.go Outdated Show resolved Hide resolved
pkg/service/record/utils.go Outdated Show resolved Hide resolved
pkg/service/record/record.go Outdated Show resolved Hide resolved
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
@EraKin575 EraKin575 requested a review from Sarthak160 May 3, 2024 06:19
Signed-off-by: Sarthak160 <rocksarthak45@gmail.com>
EraKin575 and others added 4 commits May 3, 2024 15:29
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: Sarthak160 <rocksarthak45@gmail.com>
Copy link
Member

@Sarthak160 Sarthak160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slayerjain slayerjain merged commit c0dbdbb into keploy:main May 6, 2024
17 of 18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Would be great to re-record certain test-set or testcases
3 participants