Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go test coverage #1751

Merged
merged 2 commits into from
Mar 29, 2024
Merged

fix: go test coverage #1751

merged 2 commits into from
Mar 29, 2024

Conversation

charankamarapu
Copy link
Member

@charankamarapu charankamarapu commented Mar 28, 2024

Related Issue

ISSUE :

  1. go coverage is not working because --coverage flag is now used for spinning graphQl server
  2. Tried a go-app, generic mocks are not matching because of high similarity constant.
  3. keploy test header which is added via test is causing diff in the test response because in a go-app headers in request getting repeated in the test response.

Changes:

  1. added new goCoverage flag
  2. decreased similarity constant
  3. remove keploy test header as their is no use case as of now.

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Copy link
Contributor

@re-Tick re-Tick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is an addition of config flag, I think it should also be added in the default config

@charankamarapu
Copy link
Member Author

charankamarapu commented Mar 29, 2024

Got it, done.

Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
@re-Tick
Copy link
Contributor

re-Tick commented Mar 29, 2024

LGTM

@charankamarapu charankamarapu merged commit 9473499 into main Mar 29, 2024
14 checks passed
@charankamarapu charankamarapu deleted the go_test branch March 29, 2024 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants