Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:diff strings for CLI preview #1766

Closed
wants to merge 20 commits into from
Closed

Conversation

shivamsouravjha
Copy link
Contributor

@shivamsouravjha shivamsouravjha commented Apr 1, 2024

Related Issue

  • Changed the CLI diff viewer for a better user experience.
  • added own date formatter to check for valid dates instead of using external package
  • moved from gojsondiff packages as it was flaky and unreliable moved on to more stable GJSON
  • created diffIndexRange an offset based on range to colorise difference unlike colouring the entire texts previously.
  • Handles array, map of objects, strings.

Closes: #1738

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

New:
image
Old:
image

Old:
image
New:
image

@shivamsouravjha shivamsouravjha changed the title refactor:diff strings refactor:diff strings for CLI preview Apr 1, 2024
@shivamsouravjha
Copy link
Contributor Author

image The difference for array of objects would be.

@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Fix CLI diff viewer issues with arrays
2 participants