-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Made Automatic generation of github action workflow for keploy configurable #1784
fix: Made Automatic generation of github action workflow for keploy configurable #1784
Conversation
…ly in record mode Signed-off-by: Akash Singh <akashsingh2210670@gmail.com>
Kindly review this @gouravkrosx |
@Akash-Singh04 Please update the pipeline as well, in the testing pipeline it should be false. |
@gouravkrosx Which Testing pipeline are you referring to? Is it the Github Actions workflow ? Apologies for the confusion |
@Akash-Singh04 Yes in all the workflows, it should be false. |
Signed-off-by: Akash Singh <akashsingh2210670@gmail.com>
@gouravkrosx Do review this and let me know if i have missed anything |
cli/provider/cmd.go
Outdated
|
||
defer utils.GenerateGithubActions(c.logger, c.cfg.Command) | ||
|
||
if cmd.Name() == "record" && c.cfg.GenerateGithubActions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be independent of the command, if the user has recorded test cases from an older version of keploy and now upgraded the version but directly using the test mode then in that case also keploy should generate the GitHub action.
Signed-off-by: Akash Singh <akashsingh2210670@gmail.com>
@gouravkrosx Your requested changes have been made |
…Singh04/keploy into generategithubactionsflag
LGTM! |
Related Issue
default:true
)Closes: #1780
Describe the changes you've made
default:true
)Type of change
Please let us know if any test cases are added
NIL
Please describe the tests(if any). Provide instructions how its affecting the coverage.
NIL
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)NA
A clear and concise description of it.
Checklist:
Screenshots (if any)