Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make exact match work for chunked pg req #1787

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Conversation

Sarthak160
Copy link
Member

@Sarthak160 Sarthak160 commented Apr 7, 2024

Related Issue

  • So I observed, that breaking it’s happening in case of streaming postgres requests by client in case of pooling .
    const { Pool } = require('pg');
    So currently keploy matches the request coming at the time test mode with the requests saved in the mock files . So what happening is pg client is streaming in a random order which is causing mismatch in the matching algorithm.
    for eg - in record it can give me requests in 4 chunks [P],[B],[D],[E] but in case it might give me in a single buffer or breaking in any other fashion.
    So I solved it by merging all the requests in a single buffer both for the actual requests and the saved in the mocks for uniformity and matching.
    So any pattern will at last be compared as [P,B,D,E].

Closes: #1788

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: Sarthak160 <rocksarthak45@gmail.com>
Signed-off-by: Sarthak160 <rocksarthak45@gmail.com>
@Sarthak160 Sarthak160 merged commit ba55837 into main Apr 7, 2024
14 checks passed
@Sarthak160 Sarthak160 deleted the fix-stream-match branch April 7, 2024 17:22
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: postgres breaking in test mode in case of client request streaming
2 participants